Run bundled gems spec on 3.4 #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files" This reverts commit 6f9a4a5.
…"' spec/ruby/library/csv/**/*.rb" This reverts commit e73308b.
…"' spec/ruby/library/syslog/**/*.rb" This reverts commit 91c8442.
…"' spec/ruby/library/drb/start_service_spec.rb" This reverts commit 61c5be9.
…"' spec/ruby/library/abbrev/**/*.rb" This reverts commit 0a3b781.
…"' spec/ruby/library/observer/**/*.rb" This reverts commit 3bae24c.
…"' spec/ruby/core/rational/coerce_spec.rb" This reverts commit f19402a.
This reverts commit 1d1eb5f.
…"' spec/ruby/library/bigdecimal/**/*_spec.rb" This reverts commit 96cce02.
…"' spec/ruby/library/base64/**/*_spec.rb" This reverts commit aac3f4a.
…"' spec/ruby/library/getoptlong/**/*.rb" This reverts commit 8538c30.
|
@eregon Do not revert them. We shouldn't test bundled gems at This change is not acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those were skipped on 3.4 in ruby/ruby@44d74f2#r138276491 but it seems unnecessary.