Add TCPServer#sysaccept spec #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eregon somehow I'm breaking other specs, but I don't understand why. Maybe you have some ideas? |
| thread = Thread.new { @server.sysaccept } | ||
| thread.join(0.1).should == nil | ||
| ensure | ||
| Thread.kill(thread) |
There was a problem hiding this comment.
Did not know there was the class method kill :)
You should probably join the thread after killing it:
thread.kill
thread.joinOr use the new matcher :)
There was a problem hiding this comment.
I do, but the issue is inside second spec. Because I tried to comment this one out and still see sporadic failures on travisCI
|
Updated with new matcher. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.