USA has not abolished DST yet #388
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Mar 12, 2017
| @@ -4,7 +4,7 @@ | |||
| platform_is_not :windows do | |||
| it "returns the time zone used for time" do | |||
| with_timezone("America/New_York") do | |||
| Time.now.zone.should == "EST" | |||
| Time.now.zone.should =~ /\AE[SD]T\z/ | |||
There was a problem hiding this comment.
I thought the zone short name was the same, DST or not, while looking at other specs in this file, but they all use a fixed time to avoid this problem.
|
I changed the specs to use fixed times like other specs in 9ac9550. |
eregon
added a commit
that referenced
this pull request
Mar 12, 2017
|
Also see 19c84be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.