New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run auto compact tests on platforms that support it #891
Conversation
Some platforms (ppcle for example) can't support autocompact. Don't run these tests on non-supported platforms
This is the corresponding check in CRuby tests: https://github.com/ruby/ruby/blob/3688b476710def7290e32656b200fefc538366d0/test/ruby/test_gc_compact.rb#L15-L25 |
Would it make sense for these methods to still succeed even on unsupported platforms? What happens when running those tests on unsupported platforms? |
I think ideally:
It also might fine to simply call these methods and rescue a well known exception which means unsupported and use I would much prefer not depending on a check needing Etc, GC::INTERNAL_CONSTANTS and other details which might change. |
Found the failing log:
I think it's best to just rescue |
@tenderlove Thank you for the PR and making me aware of the issue. |
@eregon thank you!! |
Some platforms (ppcle for example) can't support autocompact. Don't run
these tests on non-supported platforms
21a48d9 is causing failures on some CI machines (particularly the ones that don't support compaction). I'm not sure if this is the right way to guard against running the tests 馃槄