Add test for Float#to_i raising FloatDomainError when NaN #958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eregon
reviewed
Oct 13, 2022
core/float/shared/to_i.rb
Outdated
| @@ -1,5 +1,6 @@ | |||
| describe :float_to_i, shared: true do | |||
| it "returns self truncated to an Integer" do | |||
| -> { (0.0 / 0.0).send(@method) }.should raise_error(FloatDomainError) | |||
There was a problem hiding this comment.
Could you move this to a separate it example?
In general we shouldn't mix normal and exceptional cases in a single it, and also this behavior does not match the example description.
There was a problem hiding this comment.
Good point, will do!
|
Thanks @eregon ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all!
While working on https://github.com/natalie-lang/natalie I noticed that the specs for
to_ion Floats did not check that it raises aFloatDomainErrorwhen NaNSo adding a little extra check for that. Let me know if the assertion has been added to the correct example
Context: FloatDomainError