Finish fixed_anchor support in the JRuby ext #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am also looking into that one failure on Windows. I believe it is a bug in our regular expression engine, joni, where it improperly decodes the group name for the error message. |
|
Looks good on local runs, #56 notwithstanding. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This support was never finished, causing several tests in TestStringScannerFixedAnchor to fail. However, because of #56 I did not realize these were still failing.
@kou This can be merged and released any time, and I have confirmed in the JRuby repository that it does indeed allow all remaining
fixed_anchortests to pass. I have no explanation for #56 right now.