Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.3.0 Release #20

Merged
merged 17 commits into from
Oct 8, 2020
Merged

Prepare 0.3.0 Release #20

merged 17 commits into from
Oct 8, 2020

Commits on Oct 6, 2020

  1. Configuration menu
    Copy the full SHA
    335d2a7 View commit details
    Browse the repository at this point in the history
  2. Remove old ChangeLog.tkextlib

    This hasn't been updated in over 10 years.
    jeremyevans committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    a8c4333 View commit details
    Browse the repository at this point in the history
  3. Remove old-README.tcltklib.ja

    This doesn't appear to have been substantially updated in 15 years,
    other than being renamed multiple times.
    jeremyevans committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    fd8aeb2 View commit details
    Browse the repository at this point in the history
  4. Remove sample/binstr_usage.rb

    This fails with:
    
    lib/tk.rb:2055:in `_invoke': string contains null byte (ArgumentError)
    jeremyevans committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    02d7eaa View commit details
    Browse the repository at this point in the history
  5. Remove sample/safe-tk.rb and sample/tkoptdb-safeTk.rb

    $SAFE support is being removed and these are no longer a good example.
    jeremyevans committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    1c9b183 View commit details
    Browse the repository at this point in the history
  6. Don't override Object#method_missing

    This causes a warning.  Switch to including a module that overrides
    method_missing and calls super.
    jeremyevans committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    0f879be View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    df0d1db View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    77a98e8 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    4d4428f View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    aa4ad67 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    46f837e View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f4811f3 View commit details
    Browse the repository at this point in the history
  13. Bump version to 0.3.0

    jeremyevans committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    b688e89 View commit details
    Browse the repository at this point in the history
  14. Change Proc.new without argument to &block

    Proc.new without block no longer works in Ruby 3.  It was probably
    done as a performance improvement in earlier Ruby versions, but
    it hasn't been a performance improvement since lazy block
    activation was added in Ruby 2.5.
    
    Change Proc.new(&b) to just b when b is already the block argument
    to the method.  I'm not sure why the Proc.new call was used in this
    case, as b should already be a Proc instance.
    
    Delete some commented out methods near where code changes were made.
    jeremyevans committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    5c162c5 View commit details
    Browse the repository at this point in the history
  15. Fix Tcl_AsyncDelete: async handler deleted by the wrong thread on exit

    Mostly from pterjan on GitHub, only the const added by me to fix a
    compiler warning.
    
    Fixes ruby#12
    jeremyevans committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    9c84c0e View commit details
    Browse the repository at this point in the history
  16. Remove sample/remote-ip_sample2.rb

    This doesn't appear to run correctly, even in tk 0.2.0 before the
    recent $SAFE removal:
    
    /home/jeremy/tmp/tk/lib/multi-tk.rb:2081:in `method_missing': undefined method `_is_master_of?' for #<RemoteTkIp:0x0000003c9657c5b0> (NoMethodError)
    
    Trying to fix that by removing the protected on the method gives:
    
    /home/jeremy/tmp/tk/lib/multi-tk.rb:2713:in `deleted?': no permission to manipulate (SecurityError)
    
    On exit in both cases, you get:
    
    /home/jeremy/tmp/tk/lib/tk.rb:3013:in `_invoke': can't delete "INTERP_FINALIZE_HOOK": command doesn't exist (RuntimeError)
    
    It's certainly possible these are underlying issues with lib/remote-tk.rb
    or lib/multi-tk.rb and not a problem with the sample itself, but I don't
    think it's a good idea to ship a sample that is broken.
    jeremyevans committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    71aa2cd View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2020

  1. Remove sample/tktree.rb

    This doesn't appear to work correctly even in 0.2.0.
    jeremyevans committed Oct 7, 2020
    Configuration menu
    Copy the full SHA
    d759b88 View commit details
    Browse the repository at this point in the history