-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a bug #8
fix a bug #8
Conversation
lib/tk/itemconfig.rb
Outdated
@@ -111,7 +111,7 @@ def __conv_item_keyonly_opts(id, keys) | |||
keys2 | |||
end | |||
|
|||
def itemconfig_hash_kv(id, keys, enc_mode = nil, conf = nil) | |||
def itemconfig_hash_kv(id, keys, enc_mode = [], conf = ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why conf parameter is removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that's a mistake, I'm sorry. It should be like
def itemconfig_hash_kv(id, keys, enc_mode = [], conf = [])
I believe this is fixed differently by r54575 (ruby/ruby@0318d35). |
@rhenium So why there's such a bug like this? |
@ice1000 Because it was fixed after Ruby 2.3 release and the patch didn't make into ruby_2_3 branch. |
I created a backport request at bugs.ruby-lang.org: https://bugs.ruby-lang.org/issues/13484 I'm closing this PR since I could confirm the code on the SO question successfully runs with tk gem 0.1.2. Side note: if you use Ruby 2.3 and want to use the tk gem, you need to explicitly activate the gem by calling |
Thank you |
A bug mentioned here:
http://stackoverflow.com/questions/43011258/ruby-tks-canvas-and-shapes-are-bugging-out/43476737#43476737