Support keyword arguments support partially #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Previously, methods defined with keyword arguments would have their keyword arguments ignored. ```rb def foo(x:) x.to_i end ``` → ``` def foo: -> Integer ``` With the added support for keyword arguments, keyword arguments can now be interpreted. However, the following are not yet supported - Method calls with keyword arguments keyword_hash_node because it does not support. - Optional keyword arguments The scenario test `RuntimeError: AST diff does not work well; the completely same code generates a different AST` is annoying me and I gave up.
euglena1215
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, methods defined with keyword arguments would have their keyword arguments ignored.
→
With the added support for keyword arguments, keyword arguments can now be interpreted.
However, the following are not yet supported
keyword_hash_node because it does not support.
The scenario test
RuntimeError: AST diff does not work well; the completely same code generates a different ASTis annoying me and I gave up.