Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move WIN32OLE_ prefixed classes under WIN32OLE #22

Merged
merged 9 commits into from
Jan 28, 2024
Merged

Conversation

nobu
Copy link
Member

@nobu nobu commented Dec 31, 2023

Prevent using the top-level namespace.
Also rename WIN32OLE::VARIANT as WIN32OLE::VariantType to prevent name clash with WIN32OLE::Variant, of generated document files on case-insensitive filesystems, e.g., Windows.
For the backward compatibility, old top-level names and WIN32OLE::VARIANT are aliased.

@nobu nobu requested a review from hsbt December 31, 2023 06:08
@nobu nobu marked this pull request as draft December 31, 2023 07:14
@nobu nobu marked this pull request as ready for review December 31, 2023 09:50
@nobu nobu merged commit 4b677f6 into ruby:master Jan 28, 2024
10 checks passed
@nobu nobu deleted the nesting branch January 28, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant