Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add installation method: rbenv for Windows #2915

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Add installation method: rbenv for Windows #2915

merged 2 commits into from
Dec 12, 2022

Conversation

ccmywish
Copy link
Contributor

@ccmywish ccmywish commented Dec 7, 2022

Close #2914

@ccmywish ccmywish requested review from a team as code owners December 7, 2022 13:10
hsbt
hsbt reviewed Dec 8, 2022
View reviewed changes
en/documentation/installation/index.md Outdated
{: #rbenv-for-windows}

[rbenv for Windows][rbenv-for-windows] allows you to install and
manage multiple installations of Ruby on Windows. It's written in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
manage multiple installations of Ruby on Windows. It's written in
manage multiple installations of Ruby on Windows. It's written in

https://github.com/ruby/www.ruby-lang.org/actions/runs/3639199716/jobs/6153813956#step:6:46

hsbt
hsbt reviewed Dec 8, 2022
View reviewed changes
en/documentation/installation/index.md Outdated
### rbenv for Windows
{: #rbenv-for-windows}

[rbenv for Windows][rbenv-for-windows] allows you to install and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[rbenv for Windows][rbenv-for-windows] allows you to install and
[rbenv for Windows][rbenv-for-windows] allows you to install and

same.

hsbt
hsbt reviewed Dec 8, 2022
View reviewed changes
en/documentation/installation/index.md Outdated

[rbenv for Windows][rbenv-for-windows] allows you to install and
manage multiple installations of Ruby on Windows. It's written in
PowerShell thus providing a native way to use Ruby for Windows users.
Copy link
Member

@hsbt hsbt Dec 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
PowerShell thus providing a native way to use Ruby for Windows users.
PowerShell thus providing a native way to use Ruby for Windows users.

same.

hsbt
hsbt reviewed Dec 8, 2022
View reviewed changes
en/documentation/installation/index.md Outdated
[rbenv for Windows][rbenv-for-windows] allows you to install and
manage multiple installations of Ruby on Windows. It's written in
PowerShell thus providing a native way to use Ruby for Windows users.
Besides, the command line interface is compatible with [rbenv][rbenv]
Copy link
Member

@hsbt hsbt Dec 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Besides, the command line interface is compatible with [rbenv][rbenv]
Besides, the command line interface is compatible with [rbenv][rbenv]

same.

@hsbt
Copy link
Member

hsbt commented Dec 8, 2022

@ccmywish Thank you for adding rbenv-for-windows. I'm positive to add it because I also maintain rbenv/ruby-build. Can you remove the trailing-spaces from your patch? Thanks.

@ccmywish
Copy link
Contributor Author

ccmywish commented Dec 8, 2022

@hsbt Thank you for reviewing, I've fixed it now.

@hsbt hsbt merged commit 199d0c6 into ruby:master Dec 12, 2022
@hsbt
Copy link
Member

hsbt commented Dec 12, 2022

@ccmywish 👍

@yous yous mentioned this pull request Dec 12, 2022
Open
94 tasks
riseshia added a commit to riseshia/www.ruby-lang.org that referenced this pull request Dec 29, 2022
@riseshia
Translate "Add installation method: rbenv for Windows" (ko)
aa278bd 
Follow up ruby#2915
@riseshia riseshia mentioned this pull request Dec 29, 2022
Merged
riseshia added a commit that referenced this pull request Dec 30, 2022
@riseshia @yous
Translate follow up for document update (ko) (#2943)
a6c2cf1 
* Update the instruction to subscribe the mailing lists (ko)

Follow up #2911

* Translate "Add installation method: rbenv for Windows" (ko)

Follow up #2915

* Apply suggestions from code review

Co-authored-by: Chayoung You <yousbe@gmail.com>

Co-authored-by: Chayoung You <yousbe@gmail.com>
@meisyal meisyal mentioned this pull request Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsbt hsbt hsbt left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new installation method: rbenv for Windows
2 participants
@ccmywish @hsbt