Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branch lifecycle timeline charts #2970

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Conversation

gotoken
Copy link
Member

@gotoken gotoken commented Jan 25, 2023

Added timeline diagram to resolve issue #2965.

A new property security_maintenance_date has been added to _data/branches.yml and is used to draw a different color in the security maintenance window, but the value of the property has not yet been validated.

This PR only affects two pages: /en/downloads/branches/ and /ja/downloads/. Here is a preview site
https://gleaming-blancmange-9d16b6.netlify.app/en/downloads/branches/
https://gleaming-blancmange-9d16b6.netlify.app/ja/downloads/

@gotoken gotoken requested review from a team as code owners January 25, 2023 13:02
@gotoken
Copy link
Member Author

gotoken commented Jan 25, 2023

Another change caused the test to fail https://github.com/ruby/www.ruby-lang.org/actions/runs/4006158152/jobs/6877356657.
I will update this PR after #2971 is merged.

@hsbt
Copy link
Member

hsbt commented Feb 9, 2023

Screenshot 2023-02-09 at 17 29 28

I confirmed to work this. I'm 👍 to merge this.

@hsbt hsbt merged commit 82cdd16 into ruby:master Feb 9, 2023
@yous yous mentioned this pull request Feb 10, 2023
87 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants