Parser::Builder::Default.check_lvar_name patch

See opal/opal#2195
ruby2js · Apr 13, 2021 · ab16575 · ab16575
1 parent 0efa9ef
commit ab16575
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/demo/nodetest.js b/demo/nodetest.js
@@ -19,6 +19,10 @@ assert.strictEqual(
   to_js('foo.empty?', {filters: ['functions']}),
   'foo.length == 0');
 
+assert.strictEqual(
+  to_js('1 => foo'),
+  'var foo = 1');
+
 let ast = Ruby2JS.convert('String', {file: 'a.rb'}).ast
 assert.strictEqual(ast.constructor, Ruby2JS.AST.Node)
 assert.strictEqual(ast.type, "const")

diff --git a/demo/patch.opal b/demo/patch.opal
@@ -267,3 +267,16 @@ Opal.Ruby2JS.Token.$new = function(str, ast) {
   if (ast) token.loc = ast.$location();
   return token;
 }`
+
+# https://github.com/opal/opal/issues/2195
+module Parser
+  class Builders::Default
+    def check_lvar_name(name, loc)
+      if name =~ /^[_a-z][_\w]*$/
+        # OK
+      else
+        diagnostic :error, :lvar_name, { name: name }, loc
+      end
+    end
+  end
+end