Skip to content

Commit

Permalink
Use Packwerk::OffenseCollection instead of T.untyped (#33)
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex Evanczuk committed Dec 16, 2022
1 parent 1101815 commit 7ad5518
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 12 deletions.
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
GIT
remote: https://github.com/Shopify/packwerk.git
revision: 8476bb3cd5452765ad452d36aa45ae724f1d44f5
revision: 7428f23e243a4a172ddb4e28021a732e2c9abc1a
branch: main
specs:
packwerk (2.2.1)
Expand All @@ -17,7 +17,7 @@ GIT
PATH
remote: .
specs:
danger-packwerk (0.11.0)
danger-packwerk (0.11.1)
code_ownership
danger-plugin-api (~> 1.0)
packwerk
Expand Down
4 changes: 1 addition & 3 deletions lib/danger-packwerk/packwerk_wrapper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,7 @@ def show_offenses(offenses)
''
end

# T.untyped should be Packwerk::OffenseCollection, but is currently private until
# https://github.com/Shopify/packwerk/pull/289 merges
sig { override.params(offense_collection: T.untyped, for_files: T::Set[String]).returns(String) }
sig { override.params(offense_collection: Packwerk::OffenseCollection, for_files: T::Set[String]).returns(String) }
def show_stale_violations(offense_collection, for_files)
''
end
Expand Down
2 changes: 1 addition & 1 deletion lib/danger-packwerk/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
# frozen_string_literal: true

module DangerPackwerk
VERSION = '0.11.0'
VERSION = '0.11.1'
end

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7ad5518

Please sign in to comment.