Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop emitting pack group metrics #32

Merged
merged 2 commits into from
May 5, 2023

Conversation

alexevanczuk
Copy link
Contributor

@alexevanczuk alexevanczuk commented May 5, 2023

We previously emitted pack group metrics as a way to improve the signal-to-noise ratio by focusing on violations across "pack groups."

  • Nested packs have not seen a huge adoption
  • ADR-151 (packwerk noise reduction) proposes another mechanism for prioritizing packwerk violations and reducing noise
  • Metrics associated with pack groups have seen zero engagement
  • This simplifies the DD dashboard so it's less busy.

@alexevanczuk alexevanczuk merged commit 0f79aa6 into main May 5, 2023
10 checks passed
@alexevanczuk alexevanczuk deleted the ae-stop-emitting-pack-group-data branch May 5, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants