Reduce emitted metric count by not emitting metrics with count 0 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a high cardinality of metrics with hundreds of packs due to pack to pack violation metrics.
By not emitting metrics with a value of zero, we should get way fewer metrics emitted without much loss of the information in the dashboard.
Right now, it shows "zero" values for each pack to pack relationship where there are no violations. This is not really that useful and we can infer zero based on the lack of data if we need.
Furthermore, since ZP doesn't use architecture of visibility checkers, those will stop showing up since there are always zero pack to pack violations there.