Bug/reactivation of membership

[rzkmr]

Linked Issue: #197
Cause: When user provide invalid email address. The membership reactivation page throw an error.

[leesheppard]

Hi Raj, thank you for the PR. Can you help clarify where you are correcting the issue? The reported issue was a 404 and that there was no email received. Maybe share a video of a walkthrough to show the fix working?

[rzkmr]

Hi Lee,

I tried to replicate the issue following the steps mentioned in reported issue. I could not replicate the 404 error but found error during reactivation process. Below are steps:

Step 1: Go to Log In page
Step 2: Click Reactivate Membership

Step 2: Provide invalid email and click Reactivate

The error page will displayed but not 404 error page.

Then I checked the code in reactivations_controller. I found that inside reactivate? method user. Deactivated? throw an error because user object is nil due to invalid email.

In the expose(:user) method the logic to set user object:

expose(:user) do
  params[:user].present? ? User.find_by(email: user_params[:email]) : User.new
end

This will not handle when user is not found by email.

My solution is to create new user object when user not found by email.

expose(:user) do
  user = User.find_by(email: user_params[:email]) if params[:user].present?
  user || User.new
end

After resolving the issue:

Provide Invalid email for reactivate membership

It will flash message instead of error page.