Refactoring and enhancements #25
Conversation
|
Memory adapter: https://github.com/vasilakisfil/rubycas-server-memory |
vasilakisfil
force-pushed
the
refactoring_and_enhancements
branch
from
dfc94f4
to
ae35370
Compare
|
I rebased from master and we also have green tests yay! |
|
About extracting the memory adapter in a gem: I wanted tests to be transparent with any adapter. I mean I wanted the adapter that we use in tests to be not just a set of bogus classes but real world gem that could be used by anyone and just happens to be used in our tests too. I also feel it's easier to test extra functionality of my X adapter if it's in an external gem. But we can always bring it back. |
vasilakisfil
force-pushed
the
refactoring_and_enhancements
branch
2 times, most recently
from
182c78a
to
9185acf
Compare
|
@mitfik I rebased from master, squashed them and fixed all issues except the memory adapter. Are you sure you want that in the repo? In any case I don't think it should lie under the /lib, I feel it should be under spec/ folder. |
vasilakisfil
force-pushed
the
refactoring_and_enhancements
branch
from
9185acf
to
6a40743
Compare
|
I have now the masters gemfile to make the test pass but I don't think that you have it right. In travis.yml you shouldn't add the --without development options. You want to run the test, it is expected to install the development dependencies defined in gemspec :) |
Some refactoring and enhancements Some refactoring and enhancements Vital changes for Rails integration 1) Add validation tests (+ error class in order to pass) 2) Fixed login ticket lifetime bug (maximum_unused_login_ticket_lifetime was not used in login ticket validation) 3) Add remember_me functionality in the core 4) Change how service tickets are generated. Now each service tickets inherits from TicketGrantingTicket in a way to imitate activerecord's belongs_to/has_many. 5) Other minor improvements 6) Tested with rubycas-server-rails engine Fix exception for activerecord adapter Add rake to gemfile Remove duplicate gem Add rspec to gemfile method overloading in setup hash or file Update README.md Update to rspec 3.1, fix tests, add circleci wip Update to rspec 3.1, fix tests add more specific gem versions add ruby-version for circleci update ruby version in circle.yml remove .ruby-version file Update README.md Enhance adapter pattern Extract memory adapter to another gem Add basic adapter api update version relax rake and bundler dependencies Remove in_memory adapter wip add rubycas-server-memory as test dependency in bundler refactor module methods, fix tests move module-based tickets generation api to Generations module transform validations/generations to instance methods fix tests let instead of instance vars minor changes bump version Update README.md remove root dir method fix tests User masters gemfile Add rubycas-server-memory to gemfile
vasilakisfil
force-pushed
the
refactoring_and_enhancements
branch
from
6a40743
to
1cd26ca
Compare
|
@vasilakisfil hi, sorry for late answer but I was bit offline last month due to relocation. Regarding the changes, I will take a look on that and test it asap. br |
use default so logout then login is consistent
There are many changes in this pull-request. It also breaks compatibility. I can always bring it back but I think the tickets API based on classes is much better. I tried to follow the repository pattern. I have also moved the memory adapter (used in tests) in a different gem which I would gladly transfer it to rubycas. I have also added more tests and upgraded to latest gems.
Should I squash the commits ?