MouseEventFailed is warning by default #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maschwenk
force-pushed
the
mouse-event-failed-as-warnings
branch
from
3580378
to
39b8dde
Compare
maschwenk
force-pushed
the
mouse-event-failed-as-warnings
branch
from
84f5df3
to
ee86531
Compare
|
In general looks good, but all specs are broken and this changes previous behaviour, so it's better to leave it with raise by default. |
|
Would setting the default to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #135
Seems the most flexible and useful way to configure this going forward is having all 3 settings.