Improve documentation on user agent strings #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our test suite, we also test with mobile user agents. We do this by creating several different drivers with different user agents. Coming from Selenium, I was used to set the user agent in the browser options. With no mention of the `user-agent` option in the Ferrum or Cuprite documentation, I assumed we needed to use headers:
```
driver = Capybara::Cuprite::Driver.new(app)
driver.add_header("User-Agent", "...")
```
This works fine for the first request in the driver, but subsequent requests fail due to the reset of the headers. I found out the `user-agent` browser option still works fine. I think it is worth a mention in the README so other developers also know how to set the right user-agent string for their drivers.
Mifrill
reviewed
Aug 29, 2021
Mifrill
reviewed
Aug 29, 2021
| Capybara::Cuprite::Driver.new(app, { browser_options: { 'user-agent': 'Your own user agent string' } }) | ||
| ``` | ||
|
|
||
| If you want to change the user-agent for one request, you can use the request headers. |
There was a problem hiding this comment.
🤔 this spec is passed:
it "supports User-Agent" do
@driver.add_header("User-Agent", "foo")
@session.visit "/"
expect(@driver.evaluate_script("window.navigator.userAgent")).to eq("foo")
@session.visit "/"
expect(@driver.evaluate_script("window.navigator.userAgent")).to eq("foo")
end
can you please provide the version of which you using and could you please provide a test with this behavior reproduction? It's probably a bug
There was a problem hiding this comment.
I don't have the setup running anymore, because we stopped using Cuprite due to incompatibility with our test suite. The request headers through add_header works okay, but is reset after each spec. We set the user agent in the driver before starting the suite, therefore we lost the user agent header. Only when providing the browser_options you can persist the user agent for all requests in the whole suite.
Co-authored-by: Aleksei Strizhak <alexei.mifrill.strizhak@gmail.com>
|
This sounds like a bug, it shouldn't be like that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our test suite, we also test with mobile user agents. We do this by creating several different drivers with different user agents. Coming from Selenium, I was used to set the user agent in the browser options. With no mention of the
user-agentoption in the Ferrum or Cuprite documentation, I assumed we needed to use headers:This works fine for the first request in the driver, but subsequent requests fail due to the reset of the headers. I found out the
user-agentbrowser option still works fine. I think it is worth a mention in the README so other developers also know how to set the right user-agent string for their drivers.