Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly open the devtools #252

Merged
merged 3 commits into from
Dec 13, 2023
Merged

fix: correctly open the devtools #252

merged 3 commits into from
Dec 13, 2023

Conversation

phikes
Copy link
Contributor

@phikes phikes commented Dec 12, 2023

The original debug url was deprecated apparently (I didn't confirm that; a call to page.driver.debug just opened a blank page).

Instead there is an endpoint now that allows to parse out a remote devtools frontend path (although they incorrectly call it a url).

So instead of generating a fixed debug_url now we make a request to said endpoint and parse the actual (dynamic; contains a uuid) devtools path and build a url from it.

For preliminary discussion see #161

The original debug url was deprecated apparently (I didn't confirm that;
    a call to `page.driver.debug` just opened a blank page).

Instead there is an endpoint now that allows to parse out a remote
devtools frontend path (although they incorrectly call it a url).

So instead of generating a fixed debug_url now we make a request to said
endpoint and parse the actual (dynamic; contains a uuid) devtools path
and build a url from it.
@phikes
Copy link
Contributor Author

phikes commented Dec 12, 2023

@route

@route route merged commit 9292d11 into rubycdp:main Dec 13, 2023
6 checks passed
@route
Copy link
Member

route commented Dec 13, 2023

Thanks, I'll merge and make some movements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants