Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#89 resolve warnings #100

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Issue#89 resolve warnings #100

merged 2 commits into from
Jul 29, 2020

Conversation

Mifrill
Copy link
Collaborator

@Mifrill Mifrill commented Jul 27, 2020

Closes: #89

route
route reviewed Jul 28, 2020
View reviewed changes
lib/ferrum/browser/process.rb Outdated
@@ -115,13 +115,15 @@ def restart

private

attr_accessor :user_data_dir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just put @user_data_dir = nil to initializer, because there's no sense in attr_accessor

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, thanks

@Mifrill
issue#89 resolve warning in lib/ferrum/browser/process.rb
f321f3a 
'instance variable @user_data_dir not initialized'
@Mifrill
issue#89 resolve warning in lib/ferrum/context.rb
7e97886 
assigned but unused variable - target_id
@route route merged commit 1a33d43 into rubycdp:master Jul 29, 2020
@route
Copy link
Member

route commented Jul 29, 2020

Thank you!

@Mifrill Mifrill deleted the issue#89-resolve-warnings branch February 11, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@route route route left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warnings
2 participants
@Mifrill @route