Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue#67: allow to use default_browser_options as option on init of instance Command #71

Closed
wants to merge 1 commit into from
Closed

issue#67: allow to use default_browser_options as option on init of instance Command #71

wants to merge 1 commit into from

Conversation

Mifrill
Copy link
Collaborator

@Mifrill Mifrill commented Apr 19, 2020

closes #67

@Mifrill Mifrill mentioned this pull request Apr 19, 2020
Closed
@route route marked this pull request as ready for review May 31, 2020 10:14
@route
Copy link
Member

route commented May 31, 2020

We need slightly different approach, I'm rewriting current architecture a little

@route route closed this May 31, 2020
@Mifrill
Copy link
Collaborator Author

Mifrill commented May 31, 2020

@route sure no problem, thanks for letting me know, I was going to add tests for this.

@Mifrill Mifrill deleted the support/issue#67-default_browser_options branch May 31, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove browser_options in DEFAULT_OPTIONS
2 participants
@Mifrill @route