Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove executable bit for the script files with shebang. #206

Merged

Conversation

junaruga
Copy link
Contributor

Below scripts files have executable bits.
But actually those are executed by ruby foo/bar.rb for example from Rakefile

I think If we want to run like this way, it is preferred not to have executable bits.
However if we want to execute like this way ./foo/bar.rb, we need to add shebang (#!/usr/bin/env ruby) [1]

lib/coderay/token_kinds.rb
test/functional/basic.rb
test/functional/examples.rb
test/functional/suite.rb

Could you merge it?
Thank you.

[1] https://en.wikipedia.org/wiki/Shebang_(Unix)

@korny korny self-assigned this Jan 15, 2017
@korny
Copy link
Member

korny commented Jan 15, 2017

You're right.

@korny korny merged commit c2a952b into rubychan:master Jan 15, 2017
@junaruga
Copy link
Contributor Author

Thank you for your merging.

But sorry I made a mistake for the title and comment.

"Remove executable bit for the script files with shebang."
->
"Remove executable bit for the script files without shebang."

@korny korny assigned korny and unassigned korny Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants