#to_hash should not replace nested config objects with Hash #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Config::Options#to_hash` mistakenly replaces nested `Config::Options`
objects in arrays with `Hash` objects. Consider the following code:
```ruby
> config = Config.load_files("spec/fixtures/development.yml");
> config.section.servers[0].class
Config::Options
> config.to_hash
{:size=>2, :section=>{:size=>3, :servers=>[{:name=>"yahoo.com"}, {:name=>"amazon.com"}]}}
> config.section.servers[0].class
Hash
```
Therefore, after evaluating `config.to_hash`,
`config.sections.servers[0].name` raises an exception.
This is because `Config::Options#descend_array` overwrites array elements.
This commit fixes the above problem by modifying the
`Config::Options#descend_array`.
pkuczynski
changed the title
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config::Options#to_hashmistakenly replaces nestedConfig::Optionsobjects in arrays with
Hashobjects. Consider the following code:Therefore, after evaluating
config.to_hash,config.sections.servers[0].nameraises an exception.This is because
Config::Options#descend_arrayoverwrites array elements.This commit fixes the above problem by modifying the
Config::Options#descend_array.