Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.gemspec: use funding_url rather than post_install_message #360

Merged
merged 1 commit into from
May 28, 2024

Conversation

pda
Copy link
Contributor

@pda pda commented May 27, 2024

Hello 👋🏼

This is a friendly PR to shift the request for funding from the general-purpose post_install_message to the specific funding_uri system supported by bundler 2.2+.

I think this is more in line with etiquette of the community. To quantify that with some anecdata, the main Rails app I work on has ~340 gem dependencies, and I took the time to do a clean install and observe the post_install_messages. There's 8 in total:

  • 4 API change/deprecation notice
  • 1 notice of a non-declared soft dependency on another gem
  • 1 notice regarding EOL/maintenance schedule
  • 1 nonsense from httparty
  • 1 relating to sponsorship/funding: config

Related:

If you develop a gem that needs funding, make sure you fill in the funding_uri metadata in your gemspec, like this …
… bundle fund will start reporting all of your dependencies that need funding.

https://bundler.io/blog/2020/12/09/bundler-v2-2.html

"funding_uri" => "https://example.com/donate"

— https://guides.rubygems.org/specification-reference/

Thanks! 🙏🏼

@pkuczynski
Copy link
Member

Yeah, make sense @pda, thanks!

@pkuczynski pkuczynski merged commit d02bc80 into rubyconfig:master May 28, 2024
8 checks passed
@pkuczynski
Copy link
Member

pkuczynski commented May 28, 2024

Released as 5.5.0

@pda
Copy link
Contributor Author

pda commented Jun 3, 2024

Thanks very much @pkuczynski 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants