Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show all charts checked in the filter even if there is no data #168

Closed
mpugach opened this issue Jan 26, 2017 · 10 comments
Closed

show all charts checked in the filter even if there is no data #168

mpugach opened this issue Jan 26, 2017 · 10 comments
Assignees

Comments

@mpugach
Copy link
Contributor

mpugach commented Jan 26, 2017

No description provided.

@mpugach mpugach self-assigned this Jan 26, 2017
@lmerriam
Copy link
Collaborator

Max: after playing around with charts we may need to tweak this behavior further. I will clarify today.

@lmerriam
Copy link
Collaborator

Ok, so I think this is the correct functionality.

  1. When user first loads the history, it should default to showing only charts that are present in the currently visible time period.

  2. If the user makes a particular chart visible and then navigates to a time when it is not present on their check-in, we should ideally show that the chart is empty with a light grey message that says "No data in this time period" in the middle of that chart. Is this easy to do?

@lmerriam
Copy link
Collaborator

Do you think it would be helpful to put a button at the bottom of the history that says "show all charts in this time period" when there are hidden charts?

@mpugach
Copy link
Contributor Author

mpugach commented Jan 27, 2017

Do you think it would be helpful to put a button at the bottom of the history that says "show all charts in this time period" when there are hidden charts?

I think the button worth of separate issue

@mpugach
Copy link
Contributor Author

mpugach commented Jan 27, 2017

Ok, will implement 1 and 2

@mpugach
Copy link
Contributor Author

mpugach commented Jan 27, 2017

but it is not super easy though

@lmerriam
Copy link
Collaborator

Do you have a general estimate?

@mpugach
Copy link
Contributor Author

mpugach commented Jan 27, 2017

end of the monday

edit: but on this monday we have a day off, so next day )

@lmerriam
Copy link
Collaborator

#2 is less important. If it takes more than a few hrs then we should spend time on more important things first.

mpugach added a commit that referenced this issue Jan 31, 2017
mpugach added a commit that referenced this issue Jan 31, 2017
@mpugach
Copy link
Contributor Author

mpugach commented Jan 31, 2017

deployed to staging but spotted a bug - after adding new treatment, the chart appears, but it is empty until date change

also it is hard to determine the chart color (for blank charts) while there is no trackables data

mpugach added a commit that referenced this issue Feb 2, 2017
[#168] workaround the bug when no data shown for some charts on initial render
[#168] flatten the promises structure since they were designed to be used so
mpugach added a commit that referenced this issue Feb 6, 2017
@mpugach mpugach closed this as completed Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants