-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication #76
Authentication #76
Conversation
- Login/logout button - When logged out, hide links to pages that require authentication. - Display devise flash notices
@glassjoseph I'd move the |
Thanks for the suggestion! I'll do that. |
@jcavena I'm not sure about this approach. It's DRY, yes, but won't be 'authenticate_user' method triggered for Devise controllers as well, ie. login, register and logout? |
@rafaltrojanowski I've moved the |
@glassjoseph Thanks for checking it. I've got to hand it to you, @jcavena :) |
@rafaltrojanowski Devise might do that automatically, like @glassjoseph found, but you can always |
@glassjoseph Any chance you can take a look at the merge conflicts? These may have shown up after your changes so not your fault. |
@jcavena Thanks, should be good to go now. |
# Configure the e-mail address which will be shown in Devise::Mailer, | ||
# note that it will be overwritten if you use your own mailer class | ||
# with default "from" parameter. | ||
config.mailer_sender = 'please-change-me-at-config-initializers-devise@example.com' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pollygee What email address should someone in Abalone use if they need to ask for Devise help? we should set the config to use that address.
@Thrillberg did some testing in his dev env (THANK YOU):
He ran into one problem:
But the same behavior occurs in |
Resolves #71
Description
Adds Devise gem authentication to app.
Requires authentication for accessing and uploading data. Users cannot sign up on their own and need to be added by a developer. Mailer will need to be configured in production if we want Devise emails for password reset, etc.
Type of change