Volunteer shown as actively assigned to two supervisors after being re-assigned

[cliftonmcintosh]

Expected Behavior

When a volunteer has been unassigned from a supervisor, that volunteer's listing with that supervisor should have the text "Unassigned" in the "Assign" column even after that volunteer has been assigned to a new supervisor.

Actual Behavior

When a volunteer has been unassigned from a supervisor and then the volunteer has been assigned to a new supervisor, the list of volunteers for the old supervisor has the "Unassign" button visible for the volunteer.

Steps to reproduce

• Assign a volunteer to one supervisor.
• Unassign that volunteer from that supervisor.
• Assign the volunteer to a different supervisor.
• Visit both supervisors' edit pages and note that the "Unassign" button is now visible for that volunteer on both views even though the volunteer is only actively assigned to one of them.

Screenshots and data

In this example, Lincoln Huels was unassigned from Craig Blick and then assigned to Mrs. Jarrett Dicki. Note the "is_active" flag for Lincoln's records. However, Lincoln no longer has the "Unassigned" text in the listing of Craig Blick's volunteers.

Database records

casa_development=# select sv.id, v.display_name as "volunteer", s.display_name as "supervisor", s.id as "supervisor id", sv.is_active
casa_development-# from users v
casa_development-# join supervisor_volunteers sv
casa_development-# on v.id = sv.volunteer_id
casa_development-# join users s
casa_development-# on s.id = sv.supervisor_id
casa_development-# order by s.id, v.display_name;
 id |    volunteer     |     supervisor     | supervisor id | is_active 
----+------------------+--------------------+---------------+-----------
  2 | Lincoln Huels    | Mrs. Jarrett Dicki |           101 | t
  1 | Steven Ebert     | Mrs. Jarrett Dicki |           101 | t
  3 | Lincoln Huels    | Craig Blick        |           102 | f
  5 | Nelly Schuppe II | Craig Blick        |           102 | t
(4 rows)

Mrs. Jarrett Dicki (supervisor 101), the volunteer's current supervisor, correctly has the "Unassign" button visible for Lincoln Huels

Craig Blick (supervisor 102), the volunteer's previous supervisor, incorrectly has the "Unassign" button visible for Lincoln Huels

[cliftonmcintosh]

I believe this was introduced with #765

[compwron]

Oh noooo not again
Thank you for the github issue. This definitely needs fixing

[Zrrrpy]

@cliftonmcintosh just wanted to express my gratitude for all the detail you provided in this issue – I didn't need to add anything! Thank you for making this clear and easy for a contributor to pick up.

[drborges]

I'll give this one a try. Perfect PR description 👌🏼

[cliftonmcintosh]

@drborges

One thing to note is that the volunteers to supervisors relationship is many to one right now. It seems to me that if there are two records for a volunteer in the supervisor_volunteers table, one which connects the volunteer to an old supervisor and another which connects the volunteer to a new supervisor, then the relationship should be many to many.

https://github.com/rubyforgood/casa/blob/master/app/models/user.rb#L18-L24

But I could be wrong

[compwron]

Correct, one volunteer can only be actively assigned to one supervisor at a time. We also need to keep a record of a volunteer having previously been assigned to different supervisor. Is that many-to-many? Kind of? Whatever works 😅

[drborges]

Thanks for the info @cliftonmcintosh, @compwron, I see what the problem is. I'll be working on a fix and some specs to cover that scenario.

[drborges]

@cliftonmcintosh, @compwron I believe the PR above addresses the issue. Let me know if there's anything there you'd like changed, I'm aiming to merge it at some point this afternoon.