Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hour & Minutes input for case_contact #88

Closed
Zrrrpy opened this issue Apr 12, 2020 · 2 comments · Fixed by #106
Closed

Hour & Minutes input for case_contact #88

Zrrrpy opened this issue Apr 12, 2020 · 2 comments · Fixed by #106
Labels
🗄️ Data Data safety, data storage, data querying as a genre Priority: Critical 🙌 Volunteer Work relating to the volunteer role
Projects
CASA Volunteer Portal
Milestone
2020 MVP

Comments

@Zrrrpy
Copy link
Collaborator

Zrrrpy commented Apr 12, 2020 •
edited

Part of epic #3 (volunteer dashboard) & epic #59 (data)

Currently, volunteers can only input case_contact time value in duration_minutes.

PG CASA would like a volunteer to be able to log case_contact time values in duration_minutes AND duration_hours.

Ex: 1 hr. 15 minutes

Resolution should account for calculating total case_contact durations for reporting purposes.
Ex: When an admin pulls a report of total time spent on case_contacts, that number should look like: 5 hrs 15 minutes not 3 hrs 135 minutes

Some possible ways of handling this:

  • two drop down menus: one for duration_minutes and one for duration hours
  • user inputs pre-formatted numerical text value (like the way occurred_at is handled)

See here for reference on staging
@Zrrrpy Zrrrpy created this issue from a note in CASA Volunteer Portal (To do) Apr 12, 2020
@Zrrrpy Zrrrpy changed the title Hour & Minutes input for case_contact Hour & Minutes input for case_contact Apr 12, 2020
@Zrrrpy Zrrrpy added 🙌 Volunteer Work relating to the volunteer role Status: Available 🗄️ Data Data safety, data storage, data querying as a genre Priority: Medium labels Apr 12, 2020
@compwron
Copy link
Collaborator

Note: this should not change how data is stored in the database- duration_minutes is still correct. :)

@colinsoleim
Copy link
Collaborator

I can tackle this issue!

colinsoleim added a commit to colinsoleim/casa that referenced this issue Apr 17, 2020
@colinsoleim
Adds Hour & Minutes Input for Case Contacts
e3a458a 
- Resolves Issue rubyforgood#88
- Adds case_contact model method for displaying duration_minutes as hrs + mins
- Adds helper methods to print minute and hour select_tags
- Refactors case_contacts#create to use CaseContactParameters
@colinsoleim colinsoleim mentioned this issue Apr 17, 2020
Merged
CASA Volunteer Portal automation moved this from To do to Done Apr 17, 2020
@tundal45 tundal45 added this to the MVP milestone Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🗄️ Data Data safety, data storage, data querying as a genre Priority: Critical 🙌 Volunteer Work relating to the volunteer role
Projects
CASA Volunteer Portal
Done (in prod!)
Milestone
2020 MVP
Development

Successfully merging a pull request may close this issue.

Adds Hour & Minutes Input for Case Contacts colinsoleim/casa
4 participants
@tundal45 @compwron @colinsoleim @Zrrrpy