Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds medium_type and contact_made fields to case_contacts #138

Conversation

colinsoleim
Copy link
Collaborator

@colinsoleim colinsoleim commented Apr 20, 2020

Resolves #136, #135, #121, #129

Description

  • Adds medium_type and contact_made fields to case_contacts
  • Adds inputs to relevant forms and decorators for displaying

Dependencies

  • Removed Turbolinks: I noticed that turbolinks was breaking the jquery datatables whenever the browser back button was used, and I temporarily removed it to prevent that bug. I've never spent time trying to figure out turbolinks and I always default to turning it off. Does anyone have opinions on keeping turbolinks installed?

Type of change

  • New feature (non-breaking change which adds functionality)

How will this affect user permissions?

No impact

How Has This Been Tested?

All existing RSpec tests pass, added a few tests for decorators and case_contacts requests, and locally in browser.

Screenshots

Screen Shot 2020-04-19 at 10 30 04 PM

@colinsoleim colinsoleim marked this pull request as ready for review April 20, 2020 02:34
@colinsoleim colinsoleim changed the title [WIP] Adds migration for new case_contact fields Adds medium_type and contact_made fields to case_contacts Apr 20, 2020
@compwron
Copy link
Collaborator

I am happy to temporarily remote turbolinks; we're not using it for anything right now.

I don't see the model comment annotations from the new db fields, that's weird.

I'm not entirely sure whether heroku auto-runs new migrations when deploying; I may have to run those by hand. This is a weakness in our deploy process and we should fix it.

@compwron compwron self-requested a review April 20, 2020 03:41
@compwron compwron merged commit f257af1 into rubyforgood:master Apr 20, 2020
@colinsoleim colinsoleim deleted the issue-121-add-medium-type-to-case-contacts branch April 20, 2020 03:42
@compwron
Copy link
Collaborator

I added #141 as cleanup :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add medium_type to create_table: case_contacts
2 participants