[#1759] Remove transition_aged_youth column from CSV file when importing a case #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 22, 2021 10:38
…ansition_age? method in CasaCase
…m-case-import-csv
abnersajr
suggested changes
Feb 22, 2021
| @@ -18,13 +18,13 @@ | |||
| expect { case_importer.import_cases }.to change(CasaCase, :count).by(3) | |||
|
|
|||
| # correctly imports true/false transition_aged_youth | |||
| expect(CasaCase.find_by(case_number: "CINA-01-4347").transition_aged_youth).to be_truthy | |||
| expect(CasaCase.find_by(case_number: "CINA-01-4348").transition_aged_youth).to be_falsey | |||
| expect(CasaCase.find_by(case_number: "CINA-01-4347").transition_aged_youth).to be_falsey # birth_month_year_youth is nil | |||
There was a problem hiding this comment.
If you don't expect to have this field anymore, you could remove this expect or change it to be_nil that corresponds better to the expectation.
There was a problem hiding this comment.
I generally prefer that we follow https://www.betterspecs.org/ but as long as the linter likes it, I'm ok with it.
rhian-cs
deleted the
1759-remove-transition-aged-youth_column-from-case-import-csv
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #1759
What changed, and why?
When an admin imports Cases from a CSV file, they no longer have to (or can) specify the
transition_aged_youthcolumn.When importing a case from a CSV file,
transition_aged_youthis now calculated by checking if the youth is 14 years old or older.The reference
casa_cases.csvfrom the imports page has been updated and the column has been removed.How will this affect user permissions?
transition_aged_youthwhen importing a case from a CSV file, since it is now calculated automatically.How is this tested? (please write tests!) 💖💪
Since this is a minor change, I only updated the existing tests and fixtures.
In the
casa_cases.csvfixture I changed thebirth_month_year_youthof one of the cases from 2014 to 2000, so we could test both values oftransition_aged_youth.Screenshots please :)
Nothing in the UI was changed, but here is a screenshot of the sample CSV file before and after the change.
Before
After