[#2121] Fix reset password mail hardcoded image #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 7, 2021 14:13
… favor of generic logo and text
compwron
approved these changes
Jun 8, 2021
|
Very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #2121
What changed, and why?
The "Reset password instructions" email used a hardcoded logo (and text) of Prince George CASA.
It now shows a generic CASA logo and information.
I also added a preview for the reset password mail.
How will this affect user permissions?
No permissions will be affected.
How is this tested? (please write tests!) 💖💪
Since this is only a style change, automated tests have not been written.
Manual testing:
Screenshots please :)
How the email looked before the change:
After the change:
