Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2115] Allow unsetting judge on a given CASA case #2136

Merged

Conversation

rhian-cs
Copy link
Contributor

@rhian-cs rhian-cs commented Jun 8, 2021

What github issue is this PR for, if any?

Resolves #2115

What changed, and why?

In the edit page of a given CASA case, supervisors and admins can now select a 'blank' judge from the list.

Before that, they couldn't unassign the judge from the case.

How will this affect user permissions?

Permissions have not been affected.

How is this tested? (please write tests!) 💖💪

I added some system specs to check if it was possible to assign, change and unassign a judge from a given case.

Manual testing:

  • Go to the edit page of any CASA case
  • Check if it is possible to assign a judge and click on Update
  • Go to the edit page again
  • Check if it the judge dropdown menu now shows a "-Select Judge-" option
  • Unassign the judge, and check if the judge is truly unassigned

Screenshots please :)

The "-Select Judge-" option is now available even after assigning a judge to the case.
screenshot-judge-01

@github-actions github-actions bot added erb ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Jun 8, 2021
Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! And yay tests :)

@compwron compwron merged commit fb4d5d0 into rubyforgood:main Jun 8, 2021
@rhian-cs rhian-cs deleted the 2115-allow-unsetting-judge-on-casa-cases branch June 8, 2021 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erb ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a way to unset a judge on a case
2 participants