Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flaky Test Did not Recieve Confirmation Text After Changing Supervisor to Admin #5241

Merged
merged 1 commit into from Oct 8, 2023

Conversation

tonyaraujop
Copy link
Contributor

What github issue is this PR for, if any?

Resolves #5129

What changed, and why?

Add visit supervisors_path to load supervisors list before visiting supervisors edit page and click on Change to Admin button

How will this affect user permissions?

  • Volunteer permissions:
  • Supervisor permissions:
  • Admin permissions:

How is this tested? (please write tests!) 💖💪

Screenshots please :)

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)

Feedback please? (optional)

We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9

…ng supervisors edit page and click on Change to Admin button
@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Sep 27, 2023
@FireLemons
Copy link
Collaborator

🏅

@FireLemons FireLemons merged commit 8adc231 into rubyforgood:main Oct 8, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Flaky Test Did not Recieve Confirmation Text After Changing Supervisor to Admin
2 participants