Restyle Enter Contact Details form on case contact form #5726
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5348
What changed, and why?
Updated text content to match updated design spec in figma file. Also updated contact duration input fields.
How is this tested? (please write tests!) 💖💪
Tested by existing specs.
Screenshots please :)
Desktop
Mobile
Questions
Our work currently differs from the figma in a couple of ways. Here's ours:
And here's what's in the figma
For the first difference, changing
Text/Email
isn't so straightforward because it relies on these string values that are saved to the database. Changing this input value introduces a conflict between the form and the underlying data. Any preference for how to proceed on this?For the second difference, introducing text content that directly trails the numeric input value is tricky to do and is less accessible than just having normal labels. If this is really required though, we can probably put in the work to figure out something for it.
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
![alt text](https://media.giphy.com/media/1nP7ThJFes5pgXKUNf/giphy.gif)