Allow users to use normal currency formats for purchases. #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @reese, this is awesome, thank you so much! We'll merge this in but had one further request! I just noticed that items are also incorrectly using cents instead of normal currency format. Any chance you'd want to take on that too? I'm happy to create an issue too! |
|
@seanmarcia Sure, I'd be happy to take it on. If you just make an issue for it, that'd be great, and then I can take it from there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1022
Description
This PR allows users to input normal currency values when making purchases by stripping periods, commas, and dollar signs from input before saving. The draw back is that it doesn't actually check that it's a valid input (i.e. "123$4..345" would still work), but I would imagine this is not a use case we're concerned with.
Type of change
How Has This Been Tested?
This PR includes tests that involve input with dollar signs, commas, and periods. These tests, as well as existing tests, all still pass.