Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate brakeman security scans to our Travis CI checks #1878

Closed
1 task
edwinthinks opened this issue Sep 21, 2020 · 0 comments · Fixed by #1916
Closed
1 task

Integrate brakeman security scans to our Travis CI checks #1878

edwinthinks opened this issue Sep 21, 2020 · 0 comments · Fixed by #1916

Comments

@edwinthinks
Copy link
Collaborator

Summary

We should run security scans to our TravisCI checks to better ensure we don't introduce security vulnerabilities. Let's update our Travis configuration to also run these checks and let us know if we should fix any vulnerabilities.

https://brakemanscanner.org/docs/quickstart/

Things to Consider

We should add this also to the partner application https://github.com/rubyforgood/partner

Criteria for Completion

  • TravisCI tests should fail if a pull request has a security vulnerability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants