Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup brakeman #1881

Closed

Conversation

edumoreira1506
Copy link
Contributor

Resolves #1878

Description

Setup of brakeman.

@edumoreira1506
Copy link
Contributor Author

It's working!
Screenshot from 2020-09-22 10-54-13
Now I need to fix those problems.

@seanmarcia
Copy link
Member

Awesome start, this is exciting!

@seanmarcia
Copy link
Member

I think for the email validation we should probably be using the built in rails way of doing it:

validates :email, format: { with: URI::MailTo::EMAIL_REGEXP }

@edwinthinks
Copy link
Collaborator

@giacoelho giacoelho closed this Sep 26, 2020
@edumoreira1506
Copy link
Contributor Author

Why did this PR close? ;-;

@seanmarcia
Copy link
Member

seanmarcia commented Sep 26, 2020

We wanted to get it in in our next deploy so we put out a new PR! If you want to grab everything from #1916 and reopen this we're happy to use that one so you get credit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate brakeman security scans to our Travis CI checks
4 participants