Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFG 2023] Move Distributions by county functionality #3722

Closed
2 tasks done
cielf opened this issue Jul 9, 2023 · 3 comments
Closed
2 tasks done

[RFG 2023] Move Distributions by county functionality #3722

cielf opened this issue Jul 9, 2023 · 3 comments
Assignees
Labels
Ruby for Good 2023 DC Created for Ruby for Good 2023 DC

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 9, 2023

Summary

Move the Distributions By County functionality from the dashboard to the left hand menu

Why

Part of Dashboard rework

Details

The Distributions by County report is currently accessed from a button on the distribution card in the dashboard.
This one already has its own controller and view (most of the dashboard items do not)
It should be accessed via the left hand menu by clicking "Reporting & Auditing" then "Distributions by County"

Other things you should know

We are grouping a number of dashboard-related changes together and will merge these individual changes into a long lived dashboard-related branch. We will merge this long lived branch into main when we are ready to release the whole suite.

Criteria for completion

  • Distributions by County report moved
  • Tests modified accordingly
@cielf cielf added the Ruby for Good 2023 DC Created for Ruby for Good 2023 DC label Jul 9, 2023
@leesharma leesharma self-assigned this Jul 28, 2023
@leesharma
Copy link
Collaborator

Moving this link will make it hidden to normal users since the Reporting & Auditing menu is only visible to org admins. On a similar note, one of the other reports are user-accessible by URL (Annual Report), but there's no nav link.

It sounds like we should made Reporting & Auditing visible to all users and show the appropriate reports, so I'll do that.

@cielf
Copy link
Collaborator Author

cielf commented Jul 29, 2023

Eventually (before this goes out to the banks) the links are going to be redistributed to the appropriate spots. So having them not be visible to mere mortal users in the meantime is not horrid, horrid.

scooter-dangle pushed a commit that referenced this issue Jul 29, 2023
… (#3793)

* Remove old "Distributions by County" button

* Add Distribution by County report to sidebar

* Make reports menu visible to non-admin users
@awwaiid awwaiid added QA and removed QA labels Jul 30, 2023
@awwaiid
Copy link
Collaborator

awwaiid commented Jul 30, 2023

PR done -- Overall QA and follow-up tickets will be done as part of an epic Dashboard review.

@awwaiid awwaiid closed this as completed Jul 30, 2023
@awwaiid awwaiid added this to the Dashboard Update milestone Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby for Good 2023 DC Created for Ruby for Good 2023 DC
Projects
None yet
Development

No branches or pull requests

3 participants