Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFG 2023] Remove filtering from dashboard (once all the filter-using functionality has been moved) #3724

Closed
3 tasks
cielf opened this issue Jul 9, 2023 · 3 comments
Assignees
Labels
Ruby for Good 2023 DC Created for Ruby for Good 2023 DC

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 9, 2023

Summary

Remove the filtering from the dashboard

Why

Once we've moved all the bits that are filtered, the filtering is redundant

Details

This can only be done after the reports that use the filtering are moved from the dashboard (see other RFG 2023 issues)

At that point there will be no dashboard elements requiring the filter.

Remove the filtering section at the top of the dashboard. Also remove the Items on hand information and the "Make a transfer" and "Make an adjustment" buttons

Criteria for completion

  • filtering does not appear on the dasboard
  • confirm all tests around dashboard filtering have been reworked to point to the moved cards
  • test suite passes
@cielf cielf added the Ruby for Good 2023 DC Created for Ruby for Good 2023 DC label Jul 9, 2023
@awwaiid
Copy link
Collaborator

awwaiid commented Jul 30, 2023

Also use this as an opportunity to remove unused data queries from the dashboard controller.

@awwaiid awwaiid added this to the Dashboard Update milestone Nov 12, 2023
@cielf
Copy link
Collaborator Author

cielf commented Jan 8, 2024

Formally assigning @awwaiid because I know Brock's doing a last push to get all the dashboard items in place.

@awwaiid
Copy link
Collaborator

awwaiid commented Jan 14, 2024

Done and done!

@awwaiid awwaiid closed this as completed Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby for Good 2023 DC Created for Ruby for Good 2023 DC
Projects
None yet
Development

No branches or pull requests

2 participants