Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFG 2023] Move Manufacturer Donations Cards to Donations | Manufacturer #3735

Closed
2 tasks done
cielf opened this issue Jul 10, 2023 · 8 comments
Closed
2 tasks done
Assignees
Labels
Ruby for Good 2023 DC Created for Ruby for Good 2023 DC

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 10, 2023

Summary

Move the Manufacturer Donations functionality from the dashboard to the left hand menu

Why

Part of Dashboard rework

Details

We are talking about the card accessed from the dashboard as "Manufacturer Donations"
A view containing this info will be be accessed via the left hand menu by clicking "Reporting & Auditing" then "Manufacturer Donations"
This will require a new controller and view
The card will be removed from the dashboard
Note that we'll need the filtering functionality in the new report

Other things you should know

We are grouping a number of dashboard-related changes together and will merge these individual changes into a long lived dashboard-related branch. We will merge this long lived branch into main when we are ready to release the whole suite.

We may want to make the filtering functionality a common element between all of these separate reports (if it isn't already)

Criteria for completion

  • Dashboard Manufacturer Donations functionality moved - now accessed via left hand menu Reporting & Auditing | Manufacturer Donations
  • Tests modified accordingly
@cielf cielf added the Ruby for Good 2023 DC Created for Ruby for Good 2023 DC label Jul 10, 2023
@Benabik Benabik assigned Benabik and unassigned Benabik Jul 29, 2023
@awwaiid awwaiid self-assigned this Aug 6, 2023
@awwaiid
Copy link
Collaborator

awwaiid commented Aug 6, 2023

@lokisk1155 is also working on this with me

@lokisk1155
Copy link
Collaborator

Gang gang

@lokisk1155
Copy link
Collaborator

@awwaiid I accidentally pushed to dashboard head - b2df7b1

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions github-actions bot added the stale label Sep 7, 2023
@github-actions
Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

awwaiid added a commit to lokisk1155/human-essentials that referenced this issue Nov 12, 2023
@awwaiid
Copy link
Collaborator

awwaiid commented Nov 12, 2023

I'm merging the WIP into the consolidation branch. We need to check or add-in the filters before we can close the issue.

@awwaiid awwaiid added this to the Dashboard Update milestone Nov 12, 2023
@cielf
Copy link
Collaborator Author

cielf commented Jan 8, 2024

Formally assigning @awwaiid because I know Brock's doing a last push to get all the dashboard items in place.

@github-actions github-actions bot removed the stale label Jan 9, 2024
awwaiid added a commit that referenced this issue Jan 13, 2024
…r-3735

Add the date filter to the donation report [#3735]
@awwaiid
Copy link
Collaborator

awwaiid commented Jan 14, 2024

All set!

@awwaiid awwaiid closed this as completed Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby for Good 2023 DC Created for Ruby for Good 2023 DC
Projects
None yet
4 participants