IN PROGRESS Barcode ajax

[armahillo]

To test it:

Go to /donations/new - put the mouse in the really wide field and enter a barcode string (a bunch of numbers) and press enter. Alternately just use an actual barcode reader.

Watch the console log for output.

Weird behavior:
The first time you try using it, it won't do anything, but the second time (when it shows error messages) it will work. Not sure why it's doing this.

the data object that gets returned should have the @barcode_item.to_json in it, but I don't see that coming up in the inspector.

TODO:
wire up success / failure functions to hook into the workflow. Ideally, this whole process should be generalized enough that we can drop it in for Donation, Distribution, Transfer, Adjustments

[armahillo]

Fixes #21

This is ready to be reviewed, @seanmarcia @cattywampus

[seanmarcia]

I'll review tonight unless someone else beats me to it!

[armahillo]

Wicked!

…

On Wed, Aug 9, 2017 at 4:03 PM Sean Marcia ***@***.***> wrote: I'll review tonight unless someone else beats me to it! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#119 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAeqWwGiGKeLgvR3StRIOeKIdUVB-QTEks5sWhCngaJpZM4OglPn> .

[seanmarcia]

LGTM! I added in a couple tweaks for bar code scanning so it doesn't error out if there is an empty line item at the end. (The line item that would be create from the bar code scanner.

[seanmarcia]

Also, I commented out a test that I don't think we need anymore. By adding in the proc to reject line_items before they are even created I don't think we need this anymore:

scenario "items dropdown is still repopulated even if initial submission doesn't validate" do
  item_count = @organization.items.count + 1  # Adds 1 for the "choose an item" option
  expect(page).to have_xpath("//select[@id='donation_line_items_attributes_0_item_id']/option", count: item_count)
  click_button "Create Donation"

  expect(page).to have_content("error")
  expect(page).to have_xpath("//select[@id='donation_line_items_attributes_0_item_id']/option", count: item_count)
end

The proc on accepts_nested_attributes I'm talking about is:

  accepts_nested_attributes_for :line_items,
    allow_destroy: true,
    :reject_if => proc { |li| li[:item_id].blank? && li[:quantity].blank? }

[seanmarcia]

Now that I think about it, maybe it should be:
:reject_if => proc { |li| li[:item_id].blank? || li[:quantity].blank? }

[armahillo]

I re-added the spec -- it was failing because when the line item is rejected, the resulting form has zero line items while still displaying an error message.

I just re-added a "line_items.build" to the error block if it has no line_items and that fixed the problem.

[seanmarcia]

👍