Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactory test and move logic to model - partner user invite service #3048

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions app/controllers/partners_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -108,12 +108,8 @@ def invite

def invite_partner_user
partner = current_organization.partners.find(params[:partner])
existing_partner_user = PartnerUser.find_by(email: params[:email], partner: partner.profile)
if existing_partner_user
existing_partner_user.invite!
else
PartnerUser.invite!(email: params[:email], partner: partner.profile)
end
partner_user_invite_service = PartnerUserInviteService.new(partner: partner, email: params[:email])
partner_user_invite_service.call

redirect_to partner_path(partner), notice: "We have invited #{params[:email]} to #{partner.name}!"
rescue StandardError => e
Expand Down
24 changes: 24 additions & 0 deletions app/services/partner_user_invite_service.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
class PartnerUserInviteService
include ServiceObjectErrorsMixin

def initialize(partner:, email:)
@partner = partner
@email = email
end

def call
if existing_partner_user.present?
existing_partner_user.invite!
else
PartnerUser.invite!(email: email, partner: partner.profile)
end
end

private

attr_reader :partner, :email

def existing_partner_user
@existing_partner_user ||= PartnerUser.find_by(email: email, partner: partner.profile)
end
end
11 changes: 11 additions & 0 deletions spec/factories/partner_user.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
FactoryBot.define do
factory :partner_user, class: PartnerUser do
name { "Partner User" }
sequence(:email) { |n| "partner___user_#{n}@example.com" }
partner { Partners::Partner.first || create(:partners_partner) }
password { "password!" }
password_confirmation { "password!" }
invitation_sent_at { Time.current - 1.day }
last_sign_in_at { Time.current }
end
end
33 changes: 33 additions & 0 deletions spec/requests/partners_requests_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,39 @@
end
end

describe "POST #invite_partner_user" do
subject { -> { post invite_partner_user_partner_path(default_params.merge(id: partner.id, partner: partner.id, email: email)) } }
let(:partner) { create(:partner, organization: @organization) }
let(:email) { Faker::Internet.email }
let(:fake_partner_user_invite_service) { instance_double(PartnerUserInviteService, call: -> {}) }

before do
allow(PartnerUserInviteService).to receive(:new).with(partner: partner, email: email).and_return(fake_partner_user_invite_service)
end

context 'when the invite successfully' do
it "send the invite" do
subject.call
expect(fake_partner_user_invite_service).to have_received(:call)
expect(response).to redirect_to(partner_path(partner))
expect(flash[:notice]).to eq("We have invited #{email} to #{partner.name}!")
end
end

context 'when there is an error in invite' do
let(:error_message) { 'Error message' }
before do
allow(PartnerUserInviteService).to receive(:new).and_raise(StandardError.new(error_message))
end
italomatos marked this conversation as resolved.
Show resolved Hide resolved

it 'redirect to partner url with error message' do
subject.call
expect(response).to redirect_to(partner_path(partner))
expect(flash[:error]).to eq("Failed to invite #{email} to #{partner.name} due to: #{error_message}")
end
end
end

describe "PUT #deactivate" do
let(:partner) { create(:partner, organization: @organization, status: "approved") }

Expand Down
34 changes: 34 additions & 0 deletions spec/services/partner_user_invite_service_spec.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
require "rails_helper"

describe PartnerUserInviteService, skip_seed: true do
let(:partner) { create(:partner) }
let(:email) { Faker::Internet.email }
let!(:partner_user) { instance_spy(PartnerUser) }

describe "#call" do
subject { described_class.new(partner: partner, email: email).call }

context "when the partner user exist in database" do
before do
allow(PartnerUser).to receive(:find_by).with(email: email, partner: partner.profile).and_return(partner_user)
end

it "calls invite! partner user method" do
subject
expect(partner_user).to have_received(:invite!)
end
end

context "when the partner user doesnt exist in database" do
before do
allow(PartnerUser).to receive(:invite!)
allow(PartnerUser).to receive(:find_by).with(email: email, partner: partner.profile)
end

it "calls invite! PartnerUser class method" do
subject
expect(PartnerUser).to have_received(:invite!).with(email: email, partner: partner.profile)
end
end
end
end