replace !persisted with new_record? and !empty? with any?

app/controllers/admin/base_items_controller.rb

@@ -40,7 +40,7 @@ def show
 
   def destroy
     @base_item = BaseItem.includes(:items).find(params[:id])
-    if !@base_item.items.empty? && @base_item.destroy
+    if @base_item.items.any? && @base_item.destroy
       redirect_to admin_base_items_path, notice: "Base Item deleted!"
     else
       redirect_to admin_base_items_path, alert: "Failed to delete Base Item. Are there still items attached?"

app/services/distribution_content_change_service.rb

@@ -14,7 +14,7 @@ def call
   end
 
   def any_change?
-    !updates.empty? || !removed.empty?
+    updates.any? || removed.any?
   end
 
   def changes

app/services/sync_ndbn_members.rb

@@ -19,7 +19,7 @@ def sync
           next
         elsif ndbn_member.persisted? && ndbn_member.changed?
           Rails.logger.info("#{ndbn_member.id} changed their account name from #{ndbn_member.account_name_was} to #{ndbn_member.account_name}.")
-        elsif !ndbn_member.persisted?
+        elsif ndbn_member.new_record?
           Rails.logger.info("New record found! #{ndbn_member.id} - #{ndbn_member.account_name} has been added!")
         end
 

app/views/distribution_mailer/_distribution_changes.html.erb

@@ -1,6 +1,6 @@
 <p>Here are some Items that we need change based on Human Essentials</p>
 <ul style="list-style-type:none">
-<% if !@distribution_changes[:updates].empty? %>
+<% if @distribution_changes[:updates].any? %>
     <li>Items Updated</li>
     <ol style="list-style-type:none">
         <% @distribution_changes[:updates].each do |item| %>
@@ -11,7 +11,7 @@
     </ol>
     </li>
 <% end %>
-<% if !@distribution_changes[:removed].empty? %>
+<% if @distribution_changes[:removed].any? %>
     <li>Items Removed</li>
     <ol style="list-style-type:none">
         <% @distribution_changes[:removed].each do |item| %>

app/views/distribution_mailer/partner_mailer.text.erb

@@ -4,13 +4,13 @@ From: <%= @from_email %>
 <%= @default_email_text_interpolated %>
 <% if @distribution_changes.present? %>
   Here are some Items that we need change based on Human Essentials
-  <% if !@distribution_changes[:updates].empty? %>
+  <% if @distribution_changes[:updates].any? %>
     Items Updated:
     <% @distribution_changes[:updates].each do |item| %>
     * <%= "#{item[:name]} from #{item[:old_quantity]} to #{item[:new_quantity]}" %>
     <% end %>
   <% end %>
-  <% if !@distribution_changes[:removed].empty? %>
+  <% if @distribution_changes[:removed].any? %>
     Items Removed:
     <% @distribution_changes[:removed].each do |item| %>
     * <%= item[:name] %>

app/views/distributions/show.html.erb

@@ -16,7 +16,7 @@
           </li>
           <li class="breadcrumb-item"><%= link_to "Distributions", (distributions_path) %></li>
           <li class="breadcrumb-item"><a href="#"><%= @distribution.partner.name %>
-            <% if !@distribution.new_record? %>
+            <% if @distribution.persisted? %>
               <%= "(#{@distribution.created_at.strftime("%m/%d/%Y")})" %></li>
             <% end %></a></li>
             </ol>