Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a partners approval table to the dashboard #3799

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

h-m-m
Copy link

@h-m-m h-m-m commented Jul 30, 2023

Resolves #3743

Description

See issue for requirements. Card as described is added. Added a "action" column hed over the action button because I thought that looked okay. Happy to remove it

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Tested in Firefox and Chrome in local dev. Has new system rspec tests

Screenshots

Screen Shot 2023-07-30 at 11 16 03 AM

@h-m-m h-m-m marked this pull request as ready for review July 30, 2023 15:22
@h-m-m h-m-m requested review from edwinthinks, awwaiid, Benabik, cielf and scooter-dangle and removed request for edwinthinks July 30, 2023 15:22
@scooter-dangle scooter-dangle added the Ruby for Good 2023 DC Created for Ruby for Good 2023 DC label Jul 30, 2023
@awwaiid
Copy link
Collaborator

awwaiid commented Jul 30, 2023

This looks great! I'm doing a local QA real quick.

Copy link
Collaborator

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FANTASTIC

@awwaiid awwaiid merged commit 5268b42 into dashboard Jul 30, 2023
12 checks passed
@awwaiid awwaiid deleted the 3743-partner-approval-cards branch July 30, 2023 15:36
@cielf
Copy link
Collaborator

cielf commented Jul 30, 2023

Took a quick look on staging -- does what I expect it to do! (at least for that case -- I don't want to disturb the wah of the demo at this point)

@awwaiid awwaiid added this to the Dashboard Update milestone Nov 12, 2023
Copy link
Contributor

@h-m-m: Your PR add a partners approval table to the dashboard is part of today's Human Essentials production release: 2024.05.26.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby for Good 2023 DC Created for Ruby for Good 2023 DC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants