3686 - fix for error after clicking approve request for a new partner… #3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. fixed by writing a block to supply organization information for links used in the sidebar menu as opposed to accessing organization data directly from the user which was causing the break. tests also added 3686 - added a comment to method written in the application controller
2 tasks
dorner
requested changes
Dec 8, 2023
There was a problem hiding this comment.
While this technically removes the error, it does it by showing the partner user a number of routes that they should not have access to. We need to actually handle the error and redirect the partner to an error page, directing them to log in as the organization user.
|
@dorner I gotcha. My apologies, I misunderstood what was being asked for. I'll rework this in the way being requested. |
|
It looks to me like this was superseded by a later PR. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…. fixed by writing a block to supply organization information for links used in the sidebar menu as opposed to accessing organization data directly from the user which was causing the break. tests also added
3686 - added a comment to method written in the application controller
Resolves #3686
Description
Issue with this was that the shared sidebar menu was looking for an associated organization for the current_user. The problem being not all users have associated organizations via roles. I wasn't sure about forcing an associated organization role onto a user that maybe shouldn't have that association, so I added a method that returns the associated organization either directly from the user via roles, or through the users associated partner.
List any dependencies that are required for this change. (gems, js libraries, etc.)
Include anything else we should know about. -->
Type of change
How Has This Been Tested?
Yes.
Screenshots