4066 - Add Partner User's Name when setting up new users #4072
Conversation
Add name input field in partner show view
cancelei
changed the title
Add expected test result. Co-authored-by: Brock Wilcox <awwaiid@thelackthereof.org>
cancelei
changed the title
|
Hello @dorner, I implemented feedback from other reviewers and was also looking for your feedbacks. |
| @@ -297,6 +297,7 @@ | |||
| subject.call | |||
| expect(UserInviteService).to have_received(:invite).with( | |||
| email: email, | |||
| name: partner.name, | |||
There was a problem hiding this comment.
Switch this to use the new generated name
| name: partner.name, | |
| name: name, |
|
@awwaiid I believe I have a smooth PR ready for an eye. I reviewed the files and made sure to only leave in what was necessary. Let me know, I can make adjustments till next Sunday for sure. |
awwaiid
dismissed
dorner’s stale review
I think we addressed this through this PR and through the follow-up PR where we fix the in-database default value
Thank you @awwaiid and the Core Team for the support, without it, I wouldn't be so assertive. |
|
@cancelei: Your PR |
Add name input field in partner show view
Resolves #4066
Description
Please also include relevant motivation and context.
Guide questions:
What motivated this change (if not already described in an issue)?
On a high level: Improve Org user experience when creating a new user, more on that in the issue itself.
What alternative solutions did you consider?
I considered changing the database name default settings that currently apply the "Name Not Provided" when the name is blank on the form. That would involve changing the logic of the controller with the help of the user model (for validations). But I decided to not change it, since there would be a security risk for the database that is in prod.
What are the tradeoffs for your solution?
After merging the solution, new organizational users will be able to activate a new partner user under his umbrella with or without a name. Until now, this process has been done without informing the name. Before and after, Partner Names are also editable from the dashboard.
Type of change
How Has This Been Tested?
I implemented tests within the same test files.
Some test files had some pre-existing tests that were not very resilient to the type of changes that were requested in this task. So I expanded the adjustments to pass in the name variable (sometimes called "partner.name" variable), that are needed to continue the user creation process.
Note for the reviewer: I believe that if the solution is good, maybe the tests could improve and I would be happy to receive some feedback to improve.
Screenshots
Feature:
