Add Single step invite and process partner process capability #4075

vincent-truong-dev · 2024-02-01T20:48:49Z

Closes #3432

Checklist:

I have performed a self-review of my own code,
I have commented my code, particularly in hard-to-understand areas,
I have made corresponding changes to the documentation,
I have added tests that prove my fix is effective or that my feature works,
New and existing unit tests pass locally with my changes ("bundle exec rake"),
Title include "WIP" if work is in progress.

Description

Certain banks want to skip the approval process and simply invite and approve an agency in a single step so this PR:

Allows the organization show and edit page to set new setting "Single step invite and approve partner process"
Adds Invite and approve button to partner agency which invites and approves a partner when clicked.

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ran specs

QA Test

Enabling/disabling the feature

Login as super admin

username: superadmin@example.com
  password: password!

Navigate to http://localhost:3000/diaper_bank/organization
Click Edit
Check Use single step invite and approve partner process to yes if no, or no if yes.
Refresh screen see that it is set to yes if no, and no if yes.

**Inviting and approving w/ setting on **

Create a new user in Partner agency page
See uninvited user has action Invite and approve
Click Invite and approve
See user is Approved afterwards

With setting off

Create a new user
See uninvited user has action `Invite

Screenshots

vincent-truong-dev · 2024-02-01T21:21:43Z

spec/models/event_spec.rb

+# == Schema Information
+#
+# Table name: events
+#
+#  id              :bigint           not null, primary key
+#  data            :jsonb
+#  event_time      :datetime         not null
+#  eventable_type  :string
+#  type            :string           not null
+#  created_at      :datetime         not null
+#  updated_at      :datetime         not null
+#  eventable_id    :bigint
+#  organization_id :bigint
+#  user_id         :bigint
+#


The app added this. Doesn't detract from the change, and I think it's more useful to have. Opting to keep it in.

db/schema.rb

app/controllers/partners_controller.rb

vincent-truong-dev · 2024-02-01T21:42:42Z

db/schema.rb

@@ -839,7 +839,8 @@
  end

  create_table "versions", force: :cascade do |t|
-    t.string "item_type", null: false
+    t.string "item_type"
+    t.string "{:null=>false}"


When I added not null constraint, got this. Don't think it should be here?

That is really weird... maybe it was a mistake that happened while you were developing? Check your database table for versions and drop this column if it exists.

Removed it since it shouldn't be there.

dorner

Great first draft! I had some suggestions/comments.

dorner · 2024-02-01T21:54:08Z

app/controllers/organizations_controller.rb

@@ -97,7 +97,8 @@ def organization_params
      :repackage_essentials, :distribute_monthly,
      :ndbn_member_id, :enable_child_based_requests,
      :enable_individual_requests, :enable_quantity_based_requests,
-      :ytd_on_distribution_printout, partner_form_fields: []
+      :ytd_on_distribution_printout,:use_single_step_invite_and_approve_partner_process ,


This seems like a mouthful... can we rename it to something smaller, like single_step_partner_invite?

How about one_step_partner_invite. Saw it somewhere mentioned in a previous attempt at the ticket. Flows better

app/controllers/partners_controller.rb

dorner · 2024-02-01T21:54:53Z

app/helpers/ui_helper.rb

@@ -130,6 +130,11 @@ def invite_button_to(link, options = {}, properties = {})
    _link_to link, { icon: "envelope", type: "warning", text: "Invite", size: "xs" }.merge(options), properties
  end

+  def invite_and_approve_button_to(link, options = {}, properties = {})


Do you need a separate helper here? You should be able to reuse existing helpers and just pass the text and icon into it.

Nope, I changed it to reuse existing helper.

app/controllers/partners_controller.rb

dorner · 2024-02-01T21:56:42Z

db/schema.rb

@@ -839,7 +839,8 @@
  end

  create_table "versions", force: :cascade do |t|
-    t.string "item_type", null: false
+    t.string "item_type"
+    t.string "{:null=>false}"


That is really weird... maybe it was a mistake that happened while you were developing? Check your database table for versions and drop this column if it exists.

dorner · 2024-02-01T22:03:55Z

spec/system/organization_system_spec.rb

+
+        click_on "Save"
+        expect(page).to have_content("Yes")
+      end


There should be a request spec that checks the correct button being shown on the partners page based on the value of the flag.

dorner

This looks good! Thanks for the contribution!

dorner · 2024-02-02T20:32:07Z

@vincent-truong-dev there are some failing checks - can you please address them?

spec/system/partner_system_spec.rb

vincent-truong-dev · 2024-02-03T00:57:12Z

@vincent-truong-dev there are some failing checks - can you please address them?

Addressed the failing checks, thanks. Do you need to approve the workflows for CI to run again? @dorner

dorner · 2024-02-04T15:36:01Z

@vincent-truong-dev Sorry - still some failures!

…l process in organization page

vincent-truong-dev · 2024-02-04T15:57:08Z

@vincent-truong-dev Sorry - still some failures!

Ok, it's good now! @dorner

dorner · 2024-02-07T16:20:40Z

@vincent-truong-dev now there's a conflict. 😭

vincent-truong-dev · 2024-02-07T16:48:42Z

@vincent-truong-dev now there's a conflict. 😭

Conflict addressed. 🤞 @dorner

dorner · 2024-02-07T17:03:21Z

Awesome! Thanks for your contribution!

…rubyforgood#4075)" This reverts commit f8caf36.

github-actions · 2024-02-11T15:38:04Z

@vincent-truong-dev: Your PR Add Single step invite and process partner process capability is part of today's Human Essentials production release: 2024.02.11.
Thank you very much for your contribution!

This was referenced Feb 1, 2024

Add new column use_single_step_invite_and_approve_partner_process #4071

Closed

Add feature to single step invite and approve #4074

Closed

vincent-truong-dev changed the title ~~3432 add invite and approve capability~~ Add Single step invite and process partner process capability Feb 1, 2024

vincent-truong-dev force-pushed the 3432-add-invite-and-approve-capability branch 2 times, most recently from 95170f4 to e3d71ab Compare February 1, 2024 21:08

vincent-truong-dev marked this pull request as ready for review February 1, 2024 21:19

vincent-truong-dev commented Feb 1, 2024

View reviewed changes

db/schema.rb Outdated Show resolved Hide resolved

vincent-truong-dev commented Feb 1, 2024

View reviewed changes

app/controllers/partners_controller.rb Show resolved Hide resolved

vincent-truong-dev commented Feb 1, 2024

View reviewed changes

dorner requested changes Feb 1, 2024

View reviewed changes

vincent-truong-dev force-pushed the 3432-add-invite-and-approve-capability branch 8 times, most recently from 1a7b5c9 to 656b34c Compare February 2, 2024 19:28

vincent-truong-dev requested a review from dorner February 2, 2024 20:14

dorner approved these changes Feb 2, 2024

View reviewed changes

vincent-truong-dev force-pushed the 3432-add-invite-and-approve-capability branch from 1b00ce9 to eb5a841 Compare February 3, 2024 00:24

vincent-truong-dev commented Feb 3, 2024

View reviewed changes

spec/system/partner_system_spec.rb Outdated Show resolved Hide resolved

vincent-truong-dev requested a review from dorner February 3, 2024 01:36

vincent-truong-dev force-pushed the 3432-add-invite-and-approve-capability branch from e8d5ee7 to 706b010 Compare February 4, 2024 15:50

vincent-truong-dev added 2 commits February 4, 2024 09:56

Add new column use_single_step_invite_and_approve_partner_process

93a60ac

Allow editing (enabling and disabling) of one step invite and approva…

0d42c2f

…l process in organization page

vincent-truong-dev added 13 commits February 4, 2024 09:56

Add invite and approve capability

62a19d1

Update migration to have not null constraint

c28a98a

Rename action to invite_and_approve

d374b6e

Remove extraneous add to schema.rb

f80d0e2

Remove extraneous ui helper; reuse invite button helper

b35cea7

Rename field to one_step_invite_and_approve

11c71f8

Readd mistakenly removed null false

1cb849c

Add systems spec for one step partner invite

55f6063

Change button color to yellow to match invite button

8c73ab3

Correct lint errors

189a7a2

Fix system spec

bc41edd

More accurate spec message

a4f5129

Use correct route in specs

2377839

vincent-truong-dev force-pushed the 3432-add-invite-and-approve-capability branch from 706b010 to 2377839 Compare February 4, 2024 15:56

Merge branch 'main' into 3432-add-invite-and-approve-capability

1af3ccc

dorner approved these changes Feb 7, 2024

View reviewed changes

dorner merged commit f8caf36 into rubyforgood:main Feb 7, 2024
11 checks passed

vincent-truong-dev deleted the 3432-add-invite-and-approve-capability branch February 7, 2024 17:17

vincent-truong-dev added a commit to vincent-truong-dev/human-essentials that referenced this pull request Feb 7, 2024

Revert "Add Single step invite and process partner process capability (…

a87a4c4

…rubyforgood#4075)" This reverts commit f8caf36.

This was referenced Feb 7, 2024

Revert "Add Single step invite and process partner process capability" #4088

Closed

Fix one step invite migration to run in one line adding default false and not null instead of two #4091

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Single step invite and process partner process capability #4075

Add Single step invite and process partner process capability #4075

vincent-truong-dev commented Feb 1, 2024 •

edited

vincent-truong-dev Feb 1, 2024

vincent-truong-dev Feb 1, 2024

dorner Feb 1, 2024

vincent-truong-dev Feb 2, 2024

dorner left a comment

dorner Feb 1, 2024

vincent-truong-dev Feb 2, 2024

vincent-truong-dev Feb 2, 2024

dorner Feb 1, 2024

vincent-truong-dev Feb 2, 2024

dorner Feb 1, 2024

dorner Feb 1, 2024

vincent-truong-dev Feb 2, 2024

dorner left a comment

dorner commented Feb 2, 2024

vincent-truong-dev commented Feb 3, 2024 •

edited

dorner commented Feb 4, 2024

vincent-truong-dev commented Feb 4, 2024 •

edited

dorner commented Feb 7, 2024

vincent-truong-dev commented Feb 7, 2024 •

edited

dorner commented Feb 7, 2024

github-actions bot commented Feb 11, 2024

Add Single step invite and process partner process capability #4075

Add Single step invite and process partner process capability #4075

Conversation

vincent-truong-dev commented Feb 1, 2024 • edited

Checklist:

Description

Type of change

How Has This Been Tested?

Screenshots

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dorner left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dorner left a comment

Choose a reason for hiding this comment

dorner commented Feb 2, 2024

vincent-truong-dev commented Feb 3, 2024 • edited

dorner commented Feb 4, 2024

vincent-truong-dev commented Feb 4, 2024 • edited

dorner commented Feb 7, 2024

vincent-truong-dev commented Feb 7, 2024 • edited

dorner commented Feb 7, 2024

github-actions bot commented Feb 11, 2024

vincent-truong-dev commented Feb 1, 2024 •

edited

vincent-truong-dev commented Feb 3, 2024 •

edited

vincent-truong-dev commented Feb 4, 2024 •

edited

vincent-truong-dev commented Feb 7, 2024 •

edited