Display warning if editing an audited purchase/donation #4086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-truong-dev
force-pushed
the
display-warning-if-edit
branch
from
816000e
to
0fedf2c
Compare
vincent-truong-dev
force-pushed
the
display-warning-if-edit
branch
from
317de4e
to
d2c5255
Compare
vincent-truong-dev
force-pushed
the
display-warning-if-edit
branch
3 times, most recently
from
f08978e
to
960a7d6
Compare
dorner
requested changes
Feb 13, 2024
vincent-truong-dev
force-pushed
the
display-warning-if-edit
branch
2 times, most recently
from
6a3396c
to
bc32610
Compare
| create(:audit, storage_location: storage_location3, line_items_attributes: [{item_id: storage_location3.items.first.id, quantity: 10}]) | ||
| create(:audit, storage_location: storage_location1, status: "finalized", line_items_attributes: [{item_id: storage_location1.items.first.id, quantity: 5}]) | ||
| create(:audit, storage_location: storage_location3, status: "finalized", line_items_attributes: [{item_id: storage_location3.items.first.id, quantity: 10}]) | ||
| create(:audit, storage_location: storage_location5, status: "confirmed", line_items_attributes: [{item_id: storage_location5.items.first.id, quantity: 10}]) |
There was a problem hiding this comment.
Added new audit here and an assertion below to account for non-finalized case.
dorner
requested changes
Feb 14, 2024
spec/system/donation_system_spec.rb
Outdated
| @@ -607,6 +607,56 @@ | |||
| total_quantity = find("#donation_quantity").text | |||
| expect(total_quantity).to eq "0 (Total)" | |||
| end | |||
|
|
|||
| context "when an finalized audit has been performed on the donated items" do | |||
There was a problem hiding this comment.
All 3 of these tests should be request tests, not system tests. They're not interactive, so there's no reason to run them in a browser.
There was a problem hiding this comment.
@dorner converted the system specs into request specs.
spec/system/purchase_system_spec.rb
Outdated
| @@ -295,6 +295,60 @@ | |||
| expect(page).to_not have_link("Delete") | |||
| end | |||
| end | |||
|
|
|||
| context "when editing an existing purchase" do | |||
There was a problem hiding this comment.
@dorner these are converted now as well
vincent-truong-dev
force-pushed
the
display-warning-if-edit
branch
from
75afd74
to
bca57d3
Compare
dorner
approved these changes
Feb 16, 2024
|
@vincent-truong-dev: Your PR |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4080
Description
Displays a warning on the donation and purchase edit page if there has been an audit on the donation or purchase since their creation.
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Assume logged in
Screenshots